[Kde-hardware-devel] Review Request 111295: Secrets compability between plasma-nm and networkmanagement

Jan Grulich jgrulich at redhat.com
Sat Jun 29 08:11:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111295/
-----------------------------------------------------------

(Updated June 29, 2013, 8:11 a.m.)


Review request for Solid, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Updated again, I was too hurried. Anyway, I think I could already push this :)


Description
-------

As I promised, here is a patch that should fix secrets compatibility between both NM applets. But there is one little difference which is that VPN secrets has "secrets" key in KWallet entry (according to VPN setting property) instead of "VpnSecrets". Everything is done automatically at first start and there is no information about how many secrets were imported etc.


Diffs (updated)
-----

  editor/connectioneditor.h f8fb13f 
  editor/connectioneditor.cpp ee352d2 
  kded/secretagent.cpp dc6f648 

Diff: http://git.reviewboard.kde.org/r/111295/diff/


Testing
-------


Thanks,

Jan Grulich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130629/6dfcdc1d/attachment.html>


More information about the Kde-hardware-devel mailing list