[Kde-hardware-devel] Review Request 111366: Add ModemManager::SmsInterface

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111366/#review35541
-----------------------------------------------------------



smsinterface_p.h
<http://git.reviewboard.kde.org/r/111366/#comment26101>

    There is no need for this class to inherit from QObject. It does not emit signals, there is no slot in it and it does not use any of the other meta object features (dynamic properties, etc).



smsinterface_p.h
<http://git.reviewboard.kde.org/r/111366/#comment26102>

    Remove owner parameter. It is not used and SmsInterface's destructor already deletes this object.


- Lamarque Souza


On July 3, 2013, 5:49 p.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111366/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 5:49 p.m.)
> 
> 
> Review request for Solid, Lukáš Tinkl and Lamarque Souza.
> 
> 
> Description
> -------
> 
> Implements https://developer.gnome.org/ModemManager/0.7/gdbus-org.freedesktop.ModemManager1.Sms.html
> Renamed accordingly.
> No longer inherits from ModemInterface.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 4fa38127bf89695958f712c8770816e7adffac0c 
>   manager.cpp 29e0e0e1ca4276d3ddd0191622e822ccb3438c25 
>   modemgsmsmsinterface.h fdad802c82ae1f6f805add6c884366e79e2ed658 
>   modemgsmsmsinterface.cpp 7d248dba6e79d85d22ab5522834cbbe811960175 
>   modemgsmsmsinterface_p.h d02a2e3df3259be1cf95e7bfbc328af4024f7f21 
>   smsinterface.h PRE-CREATION 
>   smsinterface.cpp PRE-CREATION 
>   smsinterface_p.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/111366/diff/
> 
> 
> Testing
> -------
> 
> Builds.
> 
> 
> Thanks,
> 
> Anant Kamath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130703/f785c71f/attachment-0001.html>