[Kde-hardware-devel] Review Request 111366: Add ModemManager::SmsInterface

Anant Kamath kamathanant at gmail.com
Wed Jul 3 17:49:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111366/
-----------------------------------------------------------

(Updated July 3, 2013, 5:49 p.m.)


Review request for Solid, Lukáš Tinkl and Lamarque Souza.


Changes
-------

Removed QDebug include (Please ignore diff r7)


Description
-------

Implements https://developer.gnome.org/ModemManager/0.7/gdbus-org.freedesktop.ModemManager1.Sms.html
Renamed accordingly.
No longer inherits from ModemInterface.


Diffs (updated)
-----

  CMakeLists.txt 4fa38127bf89695958f712c8770816e7adffac0c 
  manager.cpp 29e0e0e1ca4276d3ddd0191622e822ccb3438c25 
  modemgsmsmsinterface.h fdad802c82ae1f6f805add6c884366e79e2ed658 
  modemgsmsmsinterface.cpp 7d248dba6e79d85d22ab5522834cbbe811960175 
  modemgsmsmsinterface_p.h d02a2e3df3259be1cf95e7bfbc328af4024f7f21 
  smsinterface.h PRE-CREATION 
  smsinterface.cpp PRE-CREATION 
  smsinterface_p.h PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/111366/diff/


Testing
-------

Builds.


Thanks,

Anant Kamath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130703/0df3debc/attachment.html>


More information about the Kde-hardware-devel mailing list