[Kde-hardware-devel] Review Request 108415: Fix rotation order in kscreen kcm to match values in xrandr and libkscreen

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108415/#review25533
-----------------------------------------------------------

Ship it!


Looks good to me, please ship together with the libkscreen patch. Thanks!

- Dan Vrátil


On Jan. 14, 2013, 8 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108415/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 8 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Dan Vrátil.
> 
> 
> Description
> -------
> 
> Since the enumeration for rotation in libkscreen was backwards between right and left the order for rotating in the kcm was also backwards (Counter clockwise was going normal -> right -> inverted -> left, which was wrong, but right because the enumeration was backwards also).  This fixes the order so the enumeration can also be fixed at the same time.
> 
> Also, note xrandr rotation angles are counter clockwise, while qml rotations are clockwise.
> 
> 
> Diffs
> -----
> 
>   kcm/qml/Output.qml 0fb3cec701b8ded7e11f1e57a02b82fa48c0d579 
>   kcm/qml/OutputControls.qml fb743ad15a28862d6ff41bd09a6c51049e473e16 
> 
> Diff: http://git.reviewboard.kde.org/r/108415/diff/
> 
> 
> Testing
> -------
> 
> It works fine here.  Also tested it was working fine before with the old enumeration values, but once those were fixed this was backwards.
> 
> 
> Thanks,
> 
> Jeremy Paul Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130114/41710af0/attachment.html>