<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108415/">http://git.reviewboard.kde.org/r/108415/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me, please ship together with the libkscreen patch. Thanks!</pre>
<br />
<p>- Dan</p>
<br />
<p>On January 14th, 2013, 8 p.m. CET, Jeremy Paul Whiting wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas and Dan Vrátil.</div>
<div>By Jeremy Paul Whiting.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2013, 8 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since the enumeration for rotation in libkscreen was backwards between right and left the order for rotating in the kcm was also backwards (Counter clockwise was going normal -> right -> inverted -> left, which was wrong, but right because the enumeration was backwards also). This fixes the order so the enumeration can also be fixed at the same time.
Also, note xrandr rotation angles are counter clockwise, while qml rotations are clockwise.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It works fine here. Also tested it was working fine before with the old enumeration values, but once those were fixed this was backwards.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcm/qml/Output.qml <span style="color: grey">(0fb3cec701b8ded7e11f1e57a02b82fa48c0d579)</span></li>
<li>kcm/qml/OutputControls.qml <span style="color: grey">(fb743ad15a28862d6ff41bd09a6c51049e473e16)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108415/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>