[Kde-hardware-devel] Review Request: Use KSystemEventFilter instead of QAbstractEventDispatcher

[Àlex Fiestas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108065/#review24416
-----------------------------------------------------------

Ship it!


Did some testing, seem to work fine. About the code can't comment much so ship it and let's see how it goes.

- Àlex Fiestas


On Jan. 1, 2013, 4:34 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108065/
> -----------------------------------------------------------
> 
> (Updated Jan. 1, 2013, 4:34 p.m.)
> 
> 
> Review request for Solid and Àlex Fiestas.
> 
> 
> Description
> -------
> 
> Use KSystemEventFilter instead of QAbstractEventDispatcher to install X11 event handler.
> 
> Using QAbstractEventDispatcher bypasses other filters installed by KSystemEventFilter and breaks others who used KSystemEventFilter to install their event handler.
> 
> This fixes the issue when our KDED module was breaking the keyboard layout KDED module. The KWindowSystem class was not delivered some X11 events and therefore the keyboard module was not notified about active window change.
> 
> 
> This addresses bug 312397.
>     http://bugs.kde.org/show_bug.cgi?id=312397
> 
> 
> Diffs
> -----
> 
>   backends/xrandr/CMakeLists.txt c8ebc9f 
>   backends/xrandr/xrandr.h 22fba74 
>   backends/xrandr/xrandr.cpp 468c8dd 
>   backends/xrandr/xrandrx11helper.h PRE-CREATION 
>   backends/xrandr/xrandrx11helper.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/108065/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130102/44757c7c/attachment.html>