<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108065/">http://git.reviewboard.kde.org/r/108065/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Did some testing, seem to work fine. About the code can't comment much so ship it and let's see how it goes.</pre>
<br />
<p>- Àlex</p>
<br />
<p>On January 1st, 2013, 4:34 p.m., Dan Vrátil wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Àlex Fiestas.</div>
<div>By Dan Vrátil.</div>
<p style="color: grey;"><i>Updated Jan. 1, 2013, 4:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use KSystemEventFilter instead of QAbstractEventDispatcher to install X11 event handler.
Using QAbstractEventDispatcher bypasses other filters installed by KSystemEventFilter and breaks others who used KSystemEventFilter to install their event handler.
This fixes the issue when our KDED module was breaking the keyboard layout KDED module. The KWindowSystem class was not delivered some X11 events and therefore the keyboard module was not notified about active window change.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=312397">312397</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/xrandr/CMakeLists.txt <span style="color: grey">(c8ebc9f)</span></li>
<li>backends/xrandr/xrandr.h <span style="color: grey">(22fba74)</span></li>
<li>backends/xrandr/xrandr.cpp <span style="color: grey">(468c8dd)</span></li>
<li>backends/xrandr/xrandrx11helper.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>backends/xrandr/xrandrx11helper.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>