[Kde-hardware-devel] Review Request 106795: Avoid race during button-triggered DPMS

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106795/#review28155
-----------------------------------------------------------


This review has been submitted with commit aaf804aead522bf1b863217c182f06ae8ab19052 by Oliver Henshaw to branch KDE/4.10.

- Commit Hook


On Oct. 11, 2012, 1:15 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106795/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 1:15 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Avoid race during button-triggered DPMS
> 
> core->onResumeFromSuspend calls SimulateUserActivity from the
> screensaver dbus interface. This seems to race with the subsequent call
> to DPMSForceLevel so that the screen re-wakes but 'xset -q' thinks it is
> off and timed dpms activation is disabled (this may be hardware dependent 
> - see https://bugzilla.redhat.com/show_bug.cgi?id=864074 for details.)
> 
> PowerDevil::Core::onResumeFromSuspend used to (optionally) lock the
> screen but this changed in a3b0089130145ad15173d1c14ab8a672b93aea65 -
> now the call is useless at best.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp a16bf7ee254b9a40c6f033c93e5ca63226469e6e 
> 
> Diff: http://git.reviewboard.kde.org/r/106795/diff/
> 
> 
> Testing
> -------
> 
> Set powerbutton to turn off screen and tested that it works.
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130226/bfedc9ac/attachment.html>