<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106795/">http://git.reviewboard.kde.org/r/106795/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit aaf804aead522bf1b863217c182f06ae8ab19052 by Oliver Henshaw to branch KDE/4.10.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 11th, 2012, 1:15 p.m. UTC, Oliver Henshaw wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Oliver Henshaw.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2012, 1:15 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid race during button-triggered DPMS
core->onResumeFromSuspend calls SimulateUserActivity from the
screensaver dbus interface. This seems to race with the subsequent call
to DPMSForceLevel so that the screen re-wakes but 'xset -q' thinks it is
off and timed dpms activation is disabled (this may be hardware dependent
- see https://bugzilla.redhat.com/show_bug.cgi?id=864074 for details.)
PowerDevil::Core::onResumeFromSuspend used to (optionally) lock the
screen but this changed in a3b0089130145ad15173d1c14ab8a672b93aea65 -
now the call is useless at best.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Set powerbutton to turn off screen and tested that it works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(a16bf7ee254b9a40c6f033c93e5ca63226469e6e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106795/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>