[Kde-hardware-devel] Review Request 108874: Only show screen/keyboard brightness if supported

Àlex Fiestas afiestas at kde.org
Sat Feb 9 16:32:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108874/
-----------------------------------------------------------

Review request for Solid and Dario Freddi.


Description
-------

External monitors brightness can't be change, so the setting is useless in all workstations.
Keyboard brightness is useless for those laptop without keyboard backlight.

This patch hide (do not load) these settings for devices that do not support them.


Diffs
-----

  powerdevil/daemon/actions/bundled/brightnesscontrol.h a081340 
  powerdevil/daemon/actions/bundled/brightnesscontrol.cpp 323905d 
  powerdevil/daemon/actions/bundled/keyboardbrightnesscontrol.h 13fd01c 
  powerdevil/daemon/actions/bundled/keyboardbrightnesscontrol.cpp 8249b17 
  powerdevil/daemon/actions/bundled/powerdevilbrightnesscontrolaction.desktop e9db51f 
  powerdevil/daemon/actions/bundled/powerdevilkeyboardbrightnesscontrolaction.desktop 3a4392a 

Diff: http://git.reviewboard.kde.org/r/108874/diff/


Testing
-------

KCM does not show brightness/keyboard options in my workstation.


Thanks,

Àlex Fiestas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130209/332d02ef/attachment.html>


More information about the Kde-hardware-devel mailing list