[Kde-hardware-devel] Review Request 107415: [High-dpi issues] Fix BluetoothDevicesDelegate with huge fonts and icon sizes

[Michael Zanetti]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107415/#review30643
-----------------------------------------------------------



src/kcmodule/bluedevildevices.cpp
<http://git.reviewboard.kde.org/r/107415/#comment22788>

    Could we fix those 2 too? Otherwise they will be left wrong forever if everything else around it is fixed.


One last inline comment. The rest looks good imho.

Regarding the top and bottom alignment. I think as long as the total size is calculated using the height of the two labels, I think the top/bottom alignment shouldn't be an issue. I agree some sort of Column would be nicer, but probably too much effort for a non-visible change. Just make sure they don't overlap with huge font sizes and we're good to go.

- Michael Zanetti


On Feb. 11, 2013, 10:50 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107415/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2013, 10:50 p.m.)
> 
> 
> Review request for Bluedevil, Àlex Fiestas and Michael Zanetti.
> 
> 
> Description
> -------
> 
> This fixes bluetooth devices delegate having overlapping fonts and small icons when using them with high dpi settings and big icon sizes, which is likely on high-dpi screens such as the Macbook Pro Retina.
> 
> 
> Diffs
> -----
> 
>   src/kcmodule/bluedevildevices.cpp 86accf5 
> 
> Diff: http://git.reviewboard.kde.org/r/107415/diff/
> 
> 
> Testing
> -------
> 
> Tested with up to 200 dpi and bigger icons. This does not fix the initial problem but is an easy fix for the most common case (ie. if I have huge fonts I am likely to have huge icons as well, so when the icons are bigger, the fonts don't overlap if they are bigger as well).
> Since there is no 48px default size, I am using Dialog icon size (default is 32) and multiply it by 1.5 to get the 48 which matches SizeLarge.
> 
> 
> Screenshots
> -----------
> 
> Bluedevil with 200 dpi
>   http://git.reviewboard.kde.org/r/107415/s/846/
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130408/d30f87c3/attachment.html>