[Kde-hardware-devel] Review Request: Fix libkscreen when running with old RandR (1.1)

[Lukáš Karas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108030/
-----------------------------------------------------------

Review request for Solid, Àlex Fiestas and Dan Vrátil.


Description
-------

If you are using libkscreen with old RandR (1.1) method XRandR::screenResources() returns NULL. It is needed check this result and prevent dereference NULL pointer.

For example if you running KDED in VNC server with RandR 1.1, you get something like this:

RandR version 1.1 too old
...
X Error: BadRequest (invalid request code or no such operation) 1
  Extension:    149 (RANDR)
  Minor opcode: 6 (RRGetScreenSizeRange)
  Resource id:  0x2e

and emtpy list of outputs...


Diffs
-----

  backends/xrandr/xrandr.cpp 468c8dd 
  backends/xrandr/xrandrconfig.cpp 91467d7 

Diff: http://git.reviewboard.kde.org/r/108030/diff/


Testing
-------


Thanks,

Lukáš Karas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121230/27b53dec/attachment-0001.html>