[Kde-hardware-devel] Review Request: Fix kscreen/KDED when running with old RandR (1.1)

[Lukáš Karas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108029/
-----------------------------------------------------------

Review request for Solid, Àlex Fiestas and Dan Vrátil.


Description
-------

It something fails and your list of outputs is empty, "embeddedOutput" will be NULL. It is better check this situation before use "embeddedOutput".

For example if you running KDED in VNC server with RandR 1.1, you get something like this:

RandR version 1.1 too old
...
X Error: BadRequest (invalid request code or no such operation) 1
  Extension:    149 (RANDR)
  Minor opcode: 6 (RRGetScreenSizeRange)
  Resource id:  0x2e

and emtpy list of outputs...


Diffs
-----

  kded/generator.cpp 4d57571 

Diff: http://git.reviewboard.kde.org/r/108029/diff/


Testing
-------


Thanks,

Lukáš Karas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121230/347212b8/attachment-0001.html>