[Kde-hardware-devel] Review Request: Make ChangeScreenSettings imply InterruptSession

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107699/#review23646
-----------------------------------------------------------


This review has been submitted with commit 04c147f4f5e7b7a5131728c04cfd14a259bf20ce by Oliver Henshaw to branch master.

- Commit Hook


On Dec. 13, 2012, 1:03 p.m., Oliver Henshaw wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107699/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 1:03 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Description
> -------
> 
> Make ChangeScreenSettings imply InterruptSession
> 
> As e.g. suspending the computer will interrupt video playing. There do
> not seem to be any use cases that require keeping the screen active
> right up to the moment that the system idles out and suspends itself.
> Indeed, PolicyAgent users that ask for ChangeScreenSettings inhibit do
> not expect the screen contents to disappear, no matter the cause.
> 
> 
> Diffs
> -----
> 
>   powerdevil/daemon/powerdevilpolicyagent.cpp d688512f0eba1c9d201c32bf5312edbe87af3c78 
> 
> Diff: http://git.reviewboard.kde.org/r/107699/diff/
> 
> 
> Testing
> -------
> 
> Verified org.kde.Solid.PowerManagement.PolicyAgent, org.freedesktop.ScreenSaver and org.freedesktop.PowerManagement.Inhibit dbus inhibitions work as expected.
> 
> 
> Thanks,
> 
> Oliver Henshaw
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20121217/afd0ca66/attachment.html>