<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107699/">http://git.reviewboard.kde.org/r/107699/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 04c147f4f5e7b7a5131728c04cfd14a259bf20ce by Oliver Henshaw to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On December 13th, 2012, 1:03 p.m., Oliver Henshaw wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Oliver Henshaw.</div>
<p style="color: grey;"><i>Updated Dec. 13, 2012, 1:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make ChangeScreenSettings imply InterruptSession
As e.g. suspending the computer will interrupt video playing. There do
not seem to be any use cases that require keeping the screen active
right up to the moment that the system idles out and suspends itself.
Indeed, PolicyAgent users that ask for ChangeScreenSettings inhibit do
not expect the screen contents to disappear, no matter the cause.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Verified org.kde.Solid.PowerManagement.PolicyAgent, org.freedesktop.ScreenSaver and org.freedesktop.PowerManagement.Inhibit dbus inhibitions work as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/powerdevilpolicyagent.cpp <span style="color: grey">(d688512f0eba1c9d201c32bf5312edbe87af3c78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107699/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>