[Kde-hardware-devel] Review Request: Show LUKS crypted partitions on local hard drive in Dolphin

[David Gilbert]

> On Sept. 5, 2011, 9:55 a.m., Lukáš Tinkl wrote:
> > Please also try to test this version with some removable USB media, otherwise the patch looks good.

checked with kvm emulated USB stick; I can still mount and unmount the crypted partition on there.

One thing to note; when mounting the USB stick crypted disk the dialog shows the name of the partition

'QEMU QEMU HARDDISK' needs a password to be accessed.

With the partition on the local emulated hard drive I don't get a name there - just '' needs a password to be accessed;
not sure if that's actually a bug or an artifact of it being an LVM partition.

The output of    solid-hardware list details   for my device is:


udi = '/org/freedesktop/UDisks/devices/dm_2d2'
  parent = '/org/freedesktop/UDisks'  (string)
  vendor = ''  (string)
  product = ''  (string)
  description = '4.0 GiB Encrypted Container'  (string)
  Block.major = 252  (0xfc)  (int)
  Block.minor = 2  (0x2)  (int)
  Block.device = '/dev/dm-2'  (string)
  StorageAccess.accessible = false  (bool)
  StorageAccess.filePath = ''  (string)
  StorageAccess.ignored = false  (bool)
  StorageVolume.ignored = false  (bool)
  StorageVolume.usage = 'Encrypted'  (0x5)  (enum)
  StorageVolume.fsType = 'crypto_LUKS'  (string)
  StorageVolume.label = ''  (string)
  StorageVolume.uuid = 'c8702279-e977-444b-bfd7-d8653a482d64'  (string)
  StorageVolume.size = 4294967296  (0x100000000)  (qulonglong)


If this is all good, then please commit (I don't have commit perms myself).

Dave


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102529/#review6273
-----------------------------------------------------------


On Sept. 4, 2011, 5:58 p.m., David Gilbert wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102529/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2011, 5:58 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> Enables LUKS encrypted partitions on local disks to be mounted from the file manager.
> 
> 
> This addresses bug 181847.
>     http://bugs.kde.org/show_bug.cgi?id=181847
> 
> 
> Diffs
> -----
> 
>   solid/solid/backends/udisks/udisksdevice.cpp c76eebc 
>   solid/solid/backends/udisks/udisksstorageaccess.h 6bf729c 
>   solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7c 
> 
> Diff: http://git.reviewboard.kde.org/r/102529/diff
> 
> 
> Testing
> -------
> 
> This version was tested in a vm on current git and used to mount and unmount a local LUKS partition.
> 
> Previous versions have been tested on my main machine with hot plug USB sticks with encryption to check those still work.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110910/202b28db/attachment.html>