<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102529/">http://git.reviewboard.kde.org/r/102529/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 5th, 2011, 9:55 a.m., <b>Lukáš Tinkl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please also try to test this version with some removable USB media, otherwise the patch looks good.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">checked with kvm emulated USB stick; I can still mount and unmount the crypted partition on there.
One thing to note; when mounting the USB stick crypted disk the dialog shows the name of the partition
'QEMU QEMU HARDDISK' needs a password to be accessed.
With the partition on the local emulated hard drive I don't get a name there - just '' needs a password to be accessed;
not sure if that's actually a bug or an artifact of it being an LVM partition.
The output of solid-hardware list details for my device is:
udi = '/org/freedesktop/UDisks/devices/dm_2d2'
parent = '/org/freedesktop/UDisks' (string)
vendor = '' (string)
product = '' (string)
description = '4.0 GiB Encrypted Container' (string)
Block.major = 252 (0xfc) (int)
Block.minor = 2 (0x2) (int)
Block.device = '/dev/dm-2' (string)
StorageAccess.accessible = false (bool)
StorageAccess.filePath = '' (string)
StorageAccess.ignored = false (bool)
StorageVolume.ignored = false (bool)
StorageVolume.usage = 'Encrypted' (0x5) (enum)
StorageVolume.fsType = 'crypto_LUKS' (string)
StorageVolume.label = '' (string)
StorageVolume.uuid = 'c8702279-e977-444b-bfd7-d8653a482d64' (string)
StorageVolume.size = 4294967296 (0x100000000) (qulonglong)
If this is all good, then please commit (I don't have commit perms myself).
Dave</pre>
<br />
<p>- David</p>
<br />
<p>On September 4th, 2011, 5:58 p.m., David Gilbert wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By David Gilbert.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2011, 5:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Enables LUKS encrypted partitions on local disks to be mounted from the file manager.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This version was tested in a vm on current git and used to mount and unmount a local LUKS partition.
Previous versions have been tested on my main machine with hot plug USB sticks with encryption to check those still work.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=181847">181847</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid/solid/backends/udisks/udisksdevice.cpp <span style="color: grey">(c76eebc)</span></li>
<li>solid/solid/backends/udisks/udisksstorageaccess.h <span style="color: grey">(6bf729c)</span></li>
<li>solid/solid/backends/udisks/udisksstorageaccess.cpp <span style="color: grey">(4cb0f7c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102529/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>