[Kde-hardware-devel] Re: Review Request: Sort out ejecting of devices

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101453/
-----------------------------------------------------------

(Updated May 30, 2011, 6:39 p.m.)


Review request for Solid, Lukáš Tinkl and Ozan Çağlayan.


Changes
-------

Removed unrelated portion of the diff


Summary
-------

Call DeviceEject only if the drive actually requires to be ejected, 
moreover call the special eject routine if the drive IS an optical Disc, not if it is NOT an optical disc…


This addresses bug 270490.
    http://bugs.kde.org/show_bug.cgi?id=270490


Diffs (updated)
-----

  solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7c 

Diff: http://git.reviewboard.kde.org/r/101453/diff


Testing
-------


Thanks,

Jacopo De

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110530/d6879785/attachment.html