[Kde-hardware-devel] Re: Review Request: Fix issue where solid fails to compile using the most recent version (0.9) of HUPnP

[Christopher Blauvelt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100768/
-----------------------------------------------------------

(Updated March 2, 2011, 5:40 p.m.)


Review request for Solid and Kevin Ottens.


Changes
-------

Added the newly created solid group to the distribution.


Summary
-------

The HUPnP backend does not compile with the most up-to-date version (0.9) of HUPnP due to API changes.  The ~HAsyncOp() function was made a pure virtual function preventing direct use of the class.  The class used was changed to HClientActionOp.  Additionally, the setUserData and userData functions were removed from HAsyncOp.  These functions were used to pass input arguments for previously invoked functions.  HClientActionOp provides a method to reference these input parameters.


This addresses bug 267283.
    http://bugs.kde.org/show_bug.cgi?id=267283


Diffs
-----

  solid/solid/backends/upnp/upnpinternetgateway.h 35f0c00 
  solid/solid/backends/upnp/upnpinternetgateway.cpp 527efe8 

Diff: http://git.reviewboard.kde.org/r/100768/diff


Testing
-------

None.  What facilities exist to test UPnP devices?


Thanks,

Christopher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110302/2c66203d/attachment.htm