[Kde-hardware-devel] Re: Review Request: Add a resumingFromSuspend signal to PowerManager::Notifier
Kevin Ottens
ervin at kde.org
Mon Jan 3 19:50:52 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6119/#review9490
-----------------------------------------------------------
No go API wise IMO. Only the signal should be in the public API and that's it, anything else is showing implementation details to the outside I think.
/trunk/KDE/kdelibs/solid/solid/powermanagement.h
<http://svn.reviewboard.kde.org/r/6119/#comment10500>
Shouldn't be public IMO. Either the signal is reliably emitted or it should never be emitted at all.
- Kevin
On 2010-12-15 14:05:42, Dario Freddi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6119/
> -----------------------------------------------------------
>
> (Updated 2010-12-15 14:05:42)
>
>
> Review request for Solid and Kevin Ottens.
>
>
> Summary
> -------
>
> This patch adds a method to connect to the resumingFromSuspend signal provided by the KDE Power Management system. In addition, I added a method to detect its availability, to prevent applications from relying on it when it's not available.
>
> P.S.: All of the new functions are @since 4.6, but I don't really know if it is 4.6 material. Kevin, I leave the decision to you.
>
>
> Diffs
> -----
>
> /trunk/KDE/kdelibs/solid/solid/powermanagement.h 1206691
> /trunk/KDE/kdelibs/solid/solid/powermanagement.cpp 1206691
> /trunk/KDE/kdelibs/solid/solid/powermanagement_p.h 1206691
>
> Diff: http://svn.reviewboard.kde.org/r/6119/diff
>
>
> Testing
> -------
>
> Compiles.
>
>
> Thanks,
>
> Dario
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110103/3ad5e580/attachment.htm
More information about the Kde-hardware-devel
mailing list