[Kde-hardware-devel] Review Request: Set dbus timeout for the unmount call to infinite

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101428/
-----------------------------------------------------------

(Updated Aug. 7, 2011, 8:19 a.m.)


Review request for Solid and Lukáš Tinkl.


Changes
-------

I talked with the udisks devs, they oppose to change their API. 
See: http://lists.freedesktop.org/archives/devkit-devel/2011-August/001132.html

They suggest to fix the issue by setting the timeout to infinite, while 
I do not like that much this approach, other ones seem much worse in terms of 
maintainability and reliability. 

Please recall that ignoring this issue might induce users to data loss.
We _need_ to fix it.


Summary (updated)
-------

Occasionally, when a long flush is taking place, the dbus call to unmount will timeout; the user receives a timeout message and 
does not know when it is safe to unplug the device anymore. This is due to a flaw in udisks api, which should not use replies but 
signals, and will be reported shortly upstream.
Meanwhile this is a reasonable workaround while we wait for new api


Diffs (updated)
-----

  solid/solid/backends/udisks/udisksstorageaccess.h 6bf729c 
  solid/solid/backends/udisks/udisksstorageaccess.cpp 4cb0f7c 

Diff: http://git.reviewboard.kde.org/r/101428/diff


Testing
-------


Thanks,

Jacopo De

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20110807/aae512f1/attachment.html>