[Kde-hardware-devel] Re: Review Request: Update NM introspection files and rebase according C++ adapter and proxy files

[Gökcen Eraslan]

> On 2010-10-11 14:32:25, Lamarque Souza wrote:
> > /trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.h, line 1
> > <http://svn.reviewboard.kde.org/r/5599/diff/1/?file=39125#file39125line1>
> >
> >     Please elaborate a little more the patch description and add the bash script you cited because it is not in the patch. What exactly this patch fixes or improves? Plasma NM depends on Network Manager solid backend, which is still in 0.7 specification. Does updating these files cause conflicts with the 0.7 solid backend? Have you tested this patch?

OK, NM DBus API has some changes in 0.8 version which includes:

* Default6 property added to ActiveConnection interface to check whether active connection is the default ipv6 connection
* AddConnection method added to org.freedesktop.NetworkManagerSettings interface to add connections over DBus
* Doc strings added/updated from introspection files

If it's planned to support system-wide connections, AddConnection method of NM is an easy way for this. It also handles Polkit authorization and calls Polkit agent for authorization. Now, you can try adding a new system-wide connection using qdbus or d-feet (and /proc/sys/kernel/random/uuid).

Now, Plasma NM does not use solid backend for all the functionality it needs, it includes the adapters for org.freedesktop.NetworkManagerSettings and org.freedesktop.NetworkManagerSettings.Connection DBus interfaces in backend/NetworkManager directory of networkmanagement. 


- Gökcen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5599/#review8077
-----------------------------------------------------------


On 2010-10-11 16:46:29, Gökcen Eraslan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5599/
> -----------------------------------------------------------
> 
> (Updated 2010-10-11 16:46:29)
> 
> 
> Review request for Network Management and KNetworkManager, Solid and Will Stephenson.
> 
> 
> Summary
> -------
> 
> * Update NM introspection files using NM-0.8.1
> * Add a generator bash script for creating cpp codes of introspection files using qdbusxml2cpp
> * Generate proxy and adapter C++ classes using updated introspection files
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.cpp 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnectionsecrets.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnectionsecrets.cpp 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/generateDbusAdapters.sh PRE-CREATION 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-active-connection.xml 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-exported-connection.xml 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-settings.xml 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-active-connectioninterface.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-active-connectioninterface.cpp 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-exported-connectioninterface.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-exported-connectioninterface.cpp 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-settingsinterface.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-settingsinterface.cpp 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-vpn-connectioninterface.h 1184809 
>   /trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-vpn-connectioninterface.cpp 1184809 
> 
> Diff: http://svn.reviewboard.kde.org/r/5599/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gökcen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101011/449d0d65/attachment.htm