<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5599/">http://svn.reviewboard.kde.org/r/5599/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 11th, 2010, 2:32 p.m., <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://svn.reviewboard.kde.org/r/5599/diff/1/?file=39125#file39125line1" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm">/*</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please elaborate a little more the patch description and add the bash script you cited because it is not in the patch. What exactly this patch fixes or improves? Plasma NM depends on Network Manager solid backend, which is still in 0.7 specification. Does updating these files cause conflicts with the 0.7 solid backend? Have you tested this patch?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, NM DBus API has some changes in 0.8 version which includes:
* Default6 property added to ActiveConnection interface to check whether active connection is the default ipv6 connection
* AddConnection method added to org.freedesktop.NetworkManagerSettings interface to add connections over DBus
* Doc strings added/updated from introspection files
If it's planned to support system-wide connections, AddConnection method of NM is an easy way for this. It also handles Polkit authorization and calls Polkit agent for authorization. Now, you can try adding a new system-wide connection using qdbus or d-feet (and /proc/sys/kernel/random/uuid).
Now, Plasma NM does not use solid backend for all the functionality it needs, it includes the adapters for org.freedesktop.NetworkManagerSettings and org.freedesktop.NetworkManagerSettings.Connection DBus interfaces in backend/NetworkManager directory of networkmanagement. </pre>
<br />
<p>- Gökcen</p>
<br />
<p>On October 11th, 2010, 4:46 p.m., Gökcen Eraslan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Network Management and KNetworkManager, Solid and Will Stephenson.</div>
<div>By Gökcen Eraslan.</div>
<p style="color: grey;"><i>Updated 2010-10-11 16:46:29</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Update NM introspection files using NM-0.8.1
* Add a generator bash script for creating cpp codes of introspection files using qdbusxml2cpp
* Generate proxy and adapter C++ classes using updated introspection files</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnection.cpp <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnectionsecrets.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/exportedconnectionsecrets.cpp <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/generateDbusAdapters.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-active-connection.xml <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-exported-connection.xml <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/introspection/nm-settings.xml <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-active-connectioninterface.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-active-connectioninterface.cpp <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-exported-connectioninterface.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-exported-connectioninterface.cpp <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-settingsinterface.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-settingsinterface.cpp <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-vpn-connectioninterface.h <span style="color: grey">(1184809)</span></li>
<li>/trunk/extragear/base/networkmanagement/backends/NetworkManager/nm-vpn-connectioninterface.cpp <span style="color: grey">(1184809)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5599/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>