[Kde-hardware-devel] Re: Review Request: Implement UDevManager::devicesFromQuery()

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5992/#review9019
-----------------------------------------------------------

Ship it!


Minor styling issue, apart from that good to commit.


/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp
<http://svn.reviewboard.kde.org/r/5992/#comment9774>

    { should be on the same line than the statement (ditto for other statements).



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp
<http://svn.reviewboard.kde.org/r/5992/#comment9773>

    No space after the &.



/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp
<http://svn.reviewboard.kde.org/r/5992/#comment9775>

    No space after &


- Kevin


On 2010-11-28 11:00:36, Pino Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5992/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 11:00:36)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> UDevManager::devicesFromQuery() is still implemented, so users of the solid library cannot do some types of devices queries.
> 
> This provides an implementation much like the upower and udisks ones. It is not an optimal implementation (queries all the devices, constructs UdevQt::Device and UDevDevice objects every time), but for now it could do the job.
> 
> I'm posting it for review for the reasons above.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1201550 
> 
> Diff: http://svn.reviewboard.kde.org/r/5992/diff
> 
> 
> Testing
> -------
> 
> Few queries done with solid-hardware, e.g.:
> $ solid-hardware query 'IS Processor'
> which returns me CPUs reported by both UDev and HAL.
> 
> 
> Thanks,
> 
> Pino
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101128/ef435d6c/attachment.htm