[Kde-hardware-devel] Review Request: Implement UDevManager::devicesFromQuery()

[Pino Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5992/
-----------------------------------------------------------

Review request for Solid.


Summary
-------

UDevManager::devicesFromQuery() is still implemented, so users of the solid library cannot do some types of devices queries.

This provides an implementation much like the upower and udisks ones. It is not an optimal implementation (queries all the devices, constructs UdevQt::Device and UDevDevice objects every time), but for now it could do the job.

I'm posting it for review for the reasons above.


Diffs
-----

  /trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp 1201550 

Diff: http://svn.reviewboard.kde.org/r/5992/diff


Testing
-------

Few queries done with solid-hardware, e.g.:
$ solid-hardware query 'IS Processor'
which returns me CPUs reported by both UDev and HAL.


Thanks,

Pino

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101128/a602e303/attachment.htm