[Kde-hardware-devel] Review Request: Kill Solid::Control::PowerManager

Dario Freddi drf54321 at gmail.com
Sun Nov 28 15:34:28 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5994/
-----------------------------------------------------------

Review request for Solid and Kevin Ottens.


Summary
-------

This patch removes Solid::Control::PowerManager. It includes also needed changes to be done to some parts of kdebase (kickoff, ksmserver, plasma) which were previously (and also uncorrectly) relying on S::C.

P.S.: I'm using git-svn so it's not a huge commit but it's a commit set consisting of a single commit for each component, and a commit for removing S::C from the tree.


Diffs
-----

  /trunk/KDE/kdebase/workspace/ksmserver/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/ksmserver/shutdowndlg.cpp 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.h 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.cpp 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.h 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager_p.h 1201731 
  /trunk/KDE/kdebase/workspace/libs/solid/control/powermanager_randr.cpp 1201731 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/core/itemhandlers.cpp 1201731 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/core/leavemodel.cpp 1201731 
  /trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp 1201731 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp 1201731 
  /trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.h 1201731 
  /trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.cpp 1201731 
  /trunk/KDE/kdebase/workspace/powerdevil/daemon/powerdevilprofilegenerator.cpp 1201711 
  /trunk/KDE/kdebase/workspace/solid/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/halpower.h 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/halpower.cpp 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/halsuspendjob.h 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/halsuspendjob.cpp 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/module_power.cpp 1201731 
  /trunk/KDE/kdebase/workspace/solid/hal/solid_hal_power.desktop 1201731 
  /trunk/KDE/kdebase/workspace/solid/solidshell/CMakeLists.txt 1201731 
  /trunk/KDE/kdebase/workspace/solid/solidshell/solid-powermanagement.h 1201731 
  /trunk/KDE/kdebase/workspace/solid/solidshell/solid-powermanagement.cpp 1201731 

Diff: http://svn.reviewboard.kde.org/r/5994/diff


Testing
-------

kdebase-workspace compiles fine


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101128/2bf2e3f3/attachment.htm 


More information about the Kde-hardware-devel mailing list