<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5994/">http://svn.reviewboard.kde.org/r/5994/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid and Kevin Ottens.</div>
<div>By Dario Freddi.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes Solid::Control::PowerManager. It includes also needed changes to be done to some parts of kdebase (kickoff, ksmserver, plasma) which were previously (and also uncorrectly) relying on S::C.
P.S.: I'm using git-svn so it's not a huge commit but it's a commit set consisting of a single commit for each component, and a commit for removing S::C from the tree.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdebase-workspace compiles fine</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdebase/workspace/ksmserver/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/ksmserver/shutdowndlg.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/ifaces/powermanager.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/powermanager.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/powermanager_p.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/libs/solid/control/powermanager_randr.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/core/itemhandlers.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/core/leavemodel.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/desktop/applets/kickoff/simpleapplet/simpleapplet.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/applets/lock_logout/lockout.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/plasma/generic/runners/powerdevil/PowerDevilRunner.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/powerdevil/daemon/powerdevilprofilegenerator.cpp <span style="color: grey">(1201711)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/halpower.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/halpower.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/halsuspendjob.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/halsuspendjob.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/module_power.cpp <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/hal/solid_hal_power.desktop <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/solidshell/CMakeLists.txt <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/solidshell/solid-powermanagement.h <span style="color: grey">(1201731)</span></li>
<li>/trunk/KDE/kdebase/workspace/solid/solidshell/solid-powermanagement.cpp <span style="color: grey">(1201731)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5994/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>