[Kde-hardware-devel] Re: Review Request: Fix description for storage volumes (UDisks)

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5896/#review8840
-----------------------------------------------------------

Ship it!


Looks good, please commit

- Lukáš


On 2010-11-18 01:46:32, Alex Merry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5896/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 01:46:32)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Summary
> -------
> 
> UDisksDevice::volumeLabel() generates a nice description for a storage volume if there is no volume label set.  However, it checks for a volume label with UDisksStorageVolume::label(), which always returns _something_, even if that is the vendor and product pair.
> 
> There are three possible fixes for this:
> * check IdLabel and PartitionLabel directly in UDisksDevice::volumeLabel() - this is what this patch does
> * change UDisksStorageVolume::label() to return an empty string if there is no label set - this is what the HAL backend does
> * never set the description to the volume label
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/backends/udisks/udisksdevice.cpp 1198123 
> 
> Diff: http://svn.reviewboard.kde.org/r/5896/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101119/c42a5c06/attachment.htm