[Kde-hardware-devel] Re: Review Request: brightness fallback mechanism for PowerDevil upower's backend

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6141/#review9295
-----------------------------------------------------------

Ship it!


Looks ok to me, even if I don't have a way to test :) a minor typo before committing


/trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/backlight_helper_actions.actions
<http://svn.reviewboard.kde.org/r/6141/#comment10176>

    s/prevent you/prevent you from


- Dario


On 2010-12-17 12:02:08, Lukáš Tinkl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6141/
> -----------------------------------------------------------
> 
> (Updated 2010-12-17 12:02:08)
> 
> 
> Review request for Solid and Dario Freddi.
> 
> 
> Summary
> -------
> 
> This patch adds a fallback mechanism for setting the display brightness to the PowerDevil upower's backend using the udev (/sys/class/backlight/) interface. It uses the KAuth framework to setup a helper application that does the actual read/writes.
> 
> 
> This addresses bug 257948.
>     https://bugs.kde.org/show_bug.cgi?id=257948
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/powerdevil/daemon/BackendConfig.cmake 1206705 
>   /trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/backlight_helper_actions.actions PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/backlighthelper.h PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/backlighthelper.cpp PRE-CREATION 
>   /trunk/KDE/kdebase/workspace/powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp 1206705 
> 
> Diff: http://svn.reviewboard.kde.org/r/6141/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lukáš
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20101217/8c9447f8/attachment.htm