[Kde-hardware-devel] Review Request: complete fstab solid backend

Kevin Ottens ervin at kde.org
Sat Aug 21 11:56:13 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/5077/#review7149
-----------------------------------------------------------

Ship it!


Only one minor whitespace issue, please fix it and commit right away.

Thanks.


/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.cpp
<http://reviewboard.kde.org/r/5077/#comment7288>

    Please remove this spurious space.


- Kevin


On 2010-08-21 09:43:07, Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/5077/
> -----------------------------------------------------------
> 
> (Updated 2010-08-21 09:43:07)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> - watch fstab to notify when a device is added or removed
> - watch mtab to notify when a device is mounted or unmounted
> - complete devicesFromQuery
> - add description in device
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.h 1166236 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp 1166236 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.h 1166236 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.cpp 1166236 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.h 1166236 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.cpp 1166236 
> 
> Diff: http://reviewboard.kde.org/r/5077/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20100821/490c8e3f/attachment.htm 


More information about the Kde-hardware-devel mailing list