[Kde-hardware-devel] Review Request: Fstab solid backend

[Kevin Ottens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4984/#review7092
-----------------------------------------------------------

Ship it!


OK, just tested the code now, seems to work fine. Thanks a lot!

I'm clearly nitpicking in the license headers now, means this code is ready to be committed. ;-)

Please address those few changes and commit right away.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp
<http://reviewboard.kde.org/r/4984/#comment7212>

    One more space here.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp
<http://reviewboard.kde.org/r/4984/#comment7213>

    One more space here.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h
<http://reviewboard.kde.org/r/4984/#comment7215>

    End of line after the "/*", to be coherent with the other files.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h
<http://reviewboard.kde.org/r/4984/#comment7216>

    And empty line missing before this one.
    
    Make the year part "2006-2010"



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h
<http://reviewboard.kde.org/r/4984/#comment7214>

    Please change the license header to refer to the same licenses than the other files. The code you borrowed comes from me and I'm fine with the license change, so let's do it right now.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.cpp
<http://reviewboard.kde.org/r/4984/#comment7217>

    Please modify the copyright header in the same way than fstabhandling.h



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.cpp
<http://reviewboard.kde.org/r/4984/#comment7218>

    The year part should be 2006-2010 there.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabservice.h
<http://reviewboard.kde.org/r/4984/#comment7220>

    Please add an end of line after "/*"



/trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabservice.h
<http://reviewboard.kde.org/r/4984/#comment7219>

    Please add an empty line before this one.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h
<http://reviewboard.kde.org/r/4984/#comment7221>

    Add one space here to be aligned with the license block.



/trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h
<http://reviewboard.kde.org/r/4984/#comment7222>

    Ditto.


- Kevin


On 2010-08-15 10:02:30, Mario Bensi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4984/
> -----------------------------------------------------------
> 
> (Updated 2010-08-15 10:02:30)
> 
> 
> Review request for Solid.
> 
> 
> Summary
> -------
> 
> Fstab solid backend. give informations and mechanism (to mount/unmount) on nfs and smb partition.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/solid/solid/CMakeLists.txt 1163886 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabhandling.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabmanager.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabservice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/fstabstorageaccess.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.h PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/backends/fstab/rootdevice.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/solid/solid/managerbase.cpp 1163886 
> 
> Diff: http://reviewboard.kde.org/r/4984/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mario
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20100816/12a1b6ff/attachment-0001.htm