[Kde-hardware-devel] Little addition to solid/control

[Kevin Ottens]

Le mercredi 22 août 2007, Juan González a écrit :
>       I've a couple features I want to add on the solid-control bluetooth
> code. They are the methods related to remote device pairing and service
> authorization, and doesn't involve much code, but as we are near a feature
> freeze, and my knowledge of the kde release system is still a bit green I
> want to get some review to be sure it's within the freeze plans, I attach
> the patch against trunk.

Looks fine to me, small enough to get in (and the freeze is not here yet). I 
assume you'll be done in time. ;-)

Just a couple of nitpicks though:
 - please don't forget to complete the API docs. Some parts are missing (I 
noticed a TODO though, but still more are missing);
 - please follow the coding style (identing and spacing), I noticed violations 
in some headers for the indenting, and implementations for the spacing.

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20070822/cfe8e184/attachment.pgp