Review Request 128952: Optionally Downscale Images on HiDPI

[Jason A. Donenfeld]

> On Sept. 20, 2016, 11:27 a.m., Aleix Pol Gonzalez wrote:
> > Maybe it would make more sense to offer downscaling for whatever scalar we're upscaling it.
> > 
> > Note though that this becomes slighlty more complex as soon as we have different dpi per screen.

Regarding your first point: see my response to bgupta above about the importance of keeping whole ratios.

Your second point: yes, this is true. I initially had added this in the X11 capture part, and tried to determine which window on which screen. But this added some complexities and difficult bugs, like windows that span multiple displays. In the end, I thought it'd be easiest to just scale based on the display/DPI used by spectacle itself. Then, if people complain in bug reports we can revisit it. And if not, great.

What do you think of that plan?


- Jason A.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128952/#review99313
-----------------------------------------------------------


On Sept. 20, 2016, 2:27 a.m., Jason A. Donenfeld wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128952/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2016, 2:27 a.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> Some people use "retina displays" or HiDPI displays. Taking screenshots
> and then posting them to the Internet is especially annoying with these
> displays, because the images are twice as big in the web browser. For
> those who primarily use Spectacle for taking web screenshots, this
> commit adds a new option (default: off) to downscale HiDPI images to the
> ordinary "1x" size so that they can be used for sharing.
> 
> In the HiDPI mode, things are usually discussed in terms of "x", where
> each "x" is actually 96 DPI. This automatic feature simply sees which
> "x" is closest by dividing the configured DPI by 96 and rounding.
> 
> Signed-off-by: Jason A. Donenfeld <Jason at zx2c4.com>
> 
> 
> Diffs
> -----
> 
>   src/ExportManager.cpp 763b1f32ad42bca1b3f1d6bcb0f7f908a54b6641 
>   src/Gui/SettingsDialog/GeneralOptionsPage.h 343ce037b7d1da9c9c12f0fe4eb44bf4a132d4fe 
>   src/Gui/SettingsDialog/GeneralOptionsPage.cpp 1ffddd9c733d3b6f3897949ab67883886f651a69 
>   src/SpectacleConfig.h 5a91f702777cde05f9608d6157d533f2e6e21347 
>   src/SpectacleConfig.cpp b812b00246421fd784d7b4646978c39fb50dfbd4 
> 
> Diff: https://git.reviewboard.kde.org/r/128952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jason A. Donenfeld
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160920/672681db/attachment.html>