<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128952/">https://git.reviewboard.kde.org/r/128952/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 20th, 2016, 11:27 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Maybe it would make more sense to offer downscaling for whatever scalar we're upscaling it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note though that this becomes slighlty more complex as soon as we have different dpi per screen.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Regarding your first point: see my response to bgupta above about the importance of keeping whole ratios.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Your second point: yes, this is true. I initially had added this in the X11 capture part, and tried to determine which window on which screen. But this added some complexities and difficult bugs, like windows that span multiple displays. In the end, I thought it'd be easiest to just scale based on the display/DPI used by spectacle itself. Then, if people complain in bug reports we can revisit it. And if not, great.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What do you think of that plan?</p></pre>
<br />
<p>- Jason A.</p>
<br />
<p>On September 20th, 2016, 2:27 a.m. UTC, Jason A. Donenfeld wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics and Boudhayan Gupta.</div>
<div>By Jason A. Donenfeld.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2016, 2:27 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
spectacle
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some people use "retina displays" or HiDPI displays. Taking screenshots
and then posting them to the Internet is especially annoying with these
displays, because the images are twice as big in the web browser. For
those who primarily use Spectacle for taking web screenshots, this
commit adds a new option (default: off) to downscale HiDPI images to the
ordinary "1x" size so that they can be used for sharing.
In the HiDPI mode, things are usually discussed in terms of "x", where
each "x" is actually 96 DPI. This automatic feature simply sees which
"x" is closest by dividing the configured DPI by 96 and rounding.
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ExportManager.cpp <span style="color: grey">(763b1f32ad42bca1b3f1d6bcb0f7f908a54b6641)</span></li>
<li>src/Gui/SettingsDialog/GeneralOptionsPage.h <span style="color: grey">(343ce037b7d1da9c9c12f0fe4eb44bf4a132d4fe)</span></li>
<li>src/Gui/SettingsDialog/GeneralOptionsPage.cpp <span style="color: grey">(1ffddd9c733d3b6f3897949ab67883886f651a69)</span></li>
<li>src/SpectacleConfig.h <span style="color: grey">(5a91f702777cde05f9608d6157d533f2e6e21347)</span></li>
<li>src/SpectacleConfig.cpp <span style="color: grey">(b812b00246421fd784d7b4646978c39fb50dfbd4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128952/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>