Review Request 129168: Show message if kipi-plugins are not installed

Peter Wu peter at lekensteyn.nl
Thu Oct 20 20:47:51 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129168/
-----------------------------------------------------------

(Updated Oct. 20, 2016, 8:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Boudhayan Gupta.


Changes
-------

Submitted with commit 47e1301926266c05976109528671192468e35b9b by Peter Wu to branch master.


Bugs: 358557
    https://bugs.kde.org/show_bug.cgi?id=358557


Repository: spectacle


Description
-------

If the kipi-plugins package is not installed as dependency of kipi (Arch
Linux) or if it failed to load due to an ABI mismatch, the Share menu
would be empty.

While at it, move setting of mKipiMenuLoaded to avoid a race condition
when the menu is opened too fast.

BUG: 358557


Diffs
-----

  src/Gui/ExportMenu.cpp 50333e0ffbfa9d382d42c6ee4c00fff1972df9a4 

Diff: https://git.reviewboard.kde.org/r/129168/diff/


Testing
-------

No kipi-plugins installed on Arch Linux, now the informational message is shown.

Installed the package, the actions are shown.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161020/71225d18/attachment-0001.html>


More information about the Kde-graphics-devel mailing list