Review Request 129168: Show message if kipi-plugins are not installed
Boudhayan Gupta
bgupta at kde.org
Mon Oct 17 05:06:51 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129168/#review100062
-----------------------------------------------------------
Ship it!
Ship It!
- Boudhayan Gupta
On Oct. 13, 2016, 6:16 a.m., Peter Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129168/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2016, 6:16 a.m.)
>
>
> Review request for KDE Graphics and Boudhayan Gupta.
>
>
> Bugs: 358557
> https://bugs.kde.org/show_bug.cgi?id=358557
>
>
> Repository: spectacle
>
>
> Description
> -------
>
> If the kipi-plugins package is not installed as dependency of kipi (Arch
> Linux) or if it failed to load due to an ABI mismatch, the Share menu
> would be empty.
>
> While at it, move setting of mKipiMenuLoaded to avoid a race condition
> when the menu is opened too fast.
>
> BUG: 358557
>
>
> Diffs
> -----
>
> src/Gui/ExportMenu.cpp 50333e0ffbfa9d382d42c6ee4c00fff1972df9a4
>
> Diff: https://git.reviewboard.kde.org/r/129168/diff/
>
>
> Testing
> -------
>
> No kipi-plugins installed on Arch Linux, now the informational message is shown.
>
> Installed the package, the actions are shown.
>
>
> Thanks,
>
> Peter Wu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161017/7745d9f1/attachment-0001.html>
More information about the Kde-graphics-devel
mailing list