Review Request 129190: Fix initial region location for High DPI screens

Peter Wu peter at lekensteyn.nl
Thu Oct 20 20:47:48 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129190/
-----------------------------------------------------------

(Updated Oct. 20, 2016, 8:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Graphics and Boudhayan Gupta.


Changes
-------

Submitted with commit 1244980882382639f35925cef1d4cf3eeb3c240c by Peter Wu to branch master.


Repository: spectacle


Description
-------

QML dimensions are measured in device-independent pixels, be sure to
make appropriate conversions. Also make sure that the new selection
size feature displays the correct dimensions.

Tested with: QT_SCALE_FACTOR=2 src/spectacle and dragging the region.

CCBUG: 357022


Diffs
-----

  src/QuickEditor/EditorRoot.qml 1719816e7d474a1022833e1a90588e75db48c059 
  src/QuickEditor/QuickEditor.cpp 035703af91441800cfd50dfac5528751054ac782 

Diff: https://git.reviewboard.kde.org/r/129190/diff/


Testing
-------

Testing per above, but the bug cannot be closed yet (will comment on that bug).


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161020/eaf03e87/attachment.html>


More information about the Kde-graphics-devel mailing list