Review Request 129190: Fix initial region location for High DPI screens

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129190/#review100060
-----------------------------------------------------------


Ship it!




I thought this issue was long closed.

Anyway, test and push as you need to.

- Boudhayan Gupta


On Oct. 15, 2016, 7:02 p.m., Peter Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129190/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2016, 7:02 p.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> QML dimensions are measured in device-independent pixels, be sure to
> make appropriate conversions. Also make sure that the new selection
> size feature displays the correct dimensions.
> 
> Tested with: QT_SCALE_FACTOR=2 src/spectacle and dragging the region.
> 
> CCBUG: 357022
> 
> 
> Diffs
> -----
> 
>   src/QuickEditor/EditorRoot.qml 1719816e7d474a1022833e1a90588e75db48c059 
>   src/QuickEditor/QuickEditor.cpp 035703af91441800cfd50dfac5528751054ac782 
> 
> Diff: https://git.reviewboard.kde.org/r/129190/diff/
> 
> 
> Testing
> -------
> 
> Testing per above, but the bug cannot be closed yet (will comment on that bug).
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161017/7db884b2/attachment.html>