Review Request 129156: Use native file dialog for the Save As option

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129156/#review99945
-----------------------------------------------------------



+1
Besides the use-cases pointed out, there's no reason to use Qt's embedded dialog.

- Aleix Pol Gonzalez


On Oct. 12, 2016, 1:31 a.m., Peter Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129156/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 1:31 a.m.)
> 
> 
> Review request for KDE Graphics, Boudhayan Gupta and Kai Uwe Broulik.
> 
> 
> Bugs: 369174
>     https://bugs.kde.org/show_bug.cgi?id=369174
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> The native file dialog has an image preview option which is lacking in
> the widget-based Qt file dialog.
> 
> 
> Diffs
> -----
> 
>   src/ExportManager.cpp 763b1f32ad42bca1b3f1d6bcb0f7f908a54b6641 
> 
> Diff: https://git.reviewboard.kde.org/r/129156/diff/
> 
> 
> Testing
> -------
> 
> Open Save As dialog, observe that the native dialog with preview option is present.
> 
> This option was added in a patch for the following bugs:
> - [Bug 357817 - Spectacle does not remember Save As location](https://bugs.kde.org/show_bug.cgi?id=357817); confirmed that the file save location is restored after restart.
> - [Bug 357818 - Spectacle does not confirm overwriting a file](https://bugs.kde.org/show_bug.cgi?id=357818); confirmed that you are still prompted to avoid an overwrite.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161012/3b71e1cd/attachment-0001.html>