Review Request 129156: Use native file dialog for the Save As option

Peter Wu peter at lekensteyn.nl
Tue Oct 11 23:31:46 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129156/
-----------------------------------------------------------

Review request for KDE Graphics, Boudhayan Gupta and Kai Uwe Broulik.


Bugs: 369174
    https://bugs.kde.org/show_bug.cgi?id=369174


Repository: spectacle


Description
-------

The native file dialog has an image preview option which is lacking in
the widget-based Qt file dialog.


Diffs
-----

  src/ExportManager.cpp 763b1f32ad42bca1b3f1d6bcb0f7f908a54b6641 

Diff: https://git.reviewboard.kde.org/r/129156/diff/


Testing
-------

Open Save As dialog, observe that the native dialog with preview option is present.

This option was added in a patch for the following bugs:
- [Bug 357817 - Spectacle does not remember Save As location](https://bugs.kde.org/show_bug.cgi?id=357817); confirmed that the file save location is restored after restart.
- [Bug 357818 - Spectacle does not confirm overwriting a file](https://bugs.kde.org/show_bug.cgi?id=357818); confirmed that you are still prompted to avoid an overwrite.


Thanks,

Peter Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161011/046820a5/attachment.html>


More information about the Kde-graphics-devel mailing list