Review Request 128404: add simple appdata file + metadata for chm, comicbook, djvu, dvi, epub, fax, fictionbook

[Matthias Klumpp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128404/#review100482
-----------------------------------------------------------




shell/org.kde.okular.appdata.xml (line 3)
<https://git.reviewboard.kde.org/r/128404/#comment67429>

    Is the .desktop file not named `org.kde.okular.desktop`? If so, consider renaming it.
    Ideally the metainfo filename should follow the .desktop filename, but that's not a fixed requirement (and it's even a better idea to keep the metainfo filename in the reverse-DNS scheme in case the .desktop file is renamed later).



shell/org.kde.okular.appdata.xml (line 29)
<https://git.reviewboard.kde.org/r/128404/#comment67430>

    Super picky: The indentation here is slightly off ;-)


- Matthias Klumpp


On Nov. 1, 2016, 6:20 p.m., Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128404/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2016, 6:20 p.m.)
> 
> 
> Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.
> 
> 
> Repository: okular
> 
> 
> Description
> -------
> 
> verified with appstreamcli validate
> 
> 
> Diffs
> -----
> 
>   generators/chm/CMakeLists.txt e54affc 
>   generators/chm/okular-chm.metainfo.xml PRE-CREATION 
>   generators/comicbook/CMakeLists.txt 4df23a6 
>   generators/comicbook/okular-comicbook.metainfo.xml PRE-CREATION 
>   generators/djvu/CMakeLists.txt 8ca545c 
>   generators/djvu/okular-djvu.metainfo.xml PRE-CREATION 
>   generators/dvi/CMakeLists.txt e95c9ca 
>   generators/dvi/okular-dvi.metainfo.xml PRE-CREATION 
>   generators/epub/CMakeLists.txt fa989ad 
>   generators/epub/okular-epub.metainfo.xml PRE-CREATION 
>   generators/fax/CMakeLists.txt f3a321c 
>   generators/fax/okular-fax.metainfo.xml PRE-CREATION 
>   generators/fictionbook/CMakeLists.txt 108568b 
>   generators/fictionbook/okular-fb.metainfo.xml PRE-CREATION 
>   shell/CMakeLists.txt d51cc7e 
>   shell/org.kde.okular.appdata.xml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128404/diff/
> 
> 
> Testing
> -------
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20161101/283aa73c/attachment.html>