<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128404/">https://git.reviewboard.kde.org/r/128404/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128404/diff/2/?file=475159#file475159line3" style="color: black; font-weight: bold; text-decoration: underline;">shell/org.kde.okular.appdata.xml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"><id></span>okular.desktop<span class="nt"></id></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is the .desktop file not named <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">org.kde.okular.desktop</code>? If so, consider renaming it.
Ideally the metainfo filename should follow the .desktop filename, but that's not a fixed requirement (and it's even a better idea to keep the metainfo filename in the reverse-DNS scheme in case the .desktop file is renamed later).</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/128404/diff/2/?file=475159#file475159line29" style="color: black; font-weight: bold; text-decoration: underline;">shell/org.kde.okular.appdata.xml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">29</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nt"></provides></span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Super picky: The indentation here is slightly off ;-)</p></pre>
</div>
</div>
<br />
<p>- Matthias Klumpp</p>
<br />
<p>On November 1st, 2016, 6:20 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Albert Astals Cid and Matthias Klumpp.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2016, 6:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
okular
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">verified with appstreamcli validate</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>generators/chm/CMakeLists.txt <span style="color: grey">(e54affc)</span></li>
<li>generators/chm/okular-chm.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/comicbook/CMakeLists.txt <span style="color: grey">(4df23a6)</span></li>
<li>generators/comicbook/okular-comicbook.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/djvu/CMakeLists.txt <span style="color: grey">(8ca545c)</span></li>
<li>generators/djvu/okular-djvu.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/dvi/CMakeLists.txt <span style="color: grey">(e95c9ca)</span></li>
<li>generators/dvi/okular-dvi.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/epub/CMakeLists.txt <span style="color: grey">(fa989ad)</span></li>
<li>generators/epub/okular-epub.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fax/CMakeLists.txt <span style="color: grey">(f3a321c)</span></li>
<li>generators/fax/okular-fax.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>generators/fictionbook/CMakeLists.txt <span style="color: grey">(108568b)</span></li>
<li>generators/fictionbook/okular-fb.metainfo.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>shell/CMakeLists.txt <span style="color: grey">(d51cc7e)</span></li>
<li>shell/org.kde.okular.appdata.xml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128404/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>