[Kde-graphics-devel] Review Request 127316: Remove unnecessary KScreen dependency

[Daniel Vrátil]

> On March 9, 2016, 7:51 p.m., Boudhayan Gupta wrote:
> > I haven't read into the source code of QScreen, but the reason I wrote this using KScreen instead of QScreen was that with KScreen I was sure I was getting data about physical screens, while with QScreen something about the documentation led me to suspect that the term "screen" encompasses a logical screen, not a physical one, and in some cases may stretch across multiple physical outputs.
> > 
> > I can give this a Ship It **only** if someone can confirm that qApp->screens() will *always* map one-to-one with physical outputs. I also strongly suspect that in Wayland we'll *have* to use KScreen anyway.

On XCB with XRandr QScreen reports the same stuff as KScreen. It is possible to configure XRandR in a way that logical screens won't map onto physical screens but then KScreen would report it like that too. I however cannot give you any testing example for I don't have multihead setup available.

On Wayland you will need to talk to compositor because you can't see other processes' windows and compositor is the only one able to do so and will probably also be the authoritative source regarding screen configuration for apps (even if backed by KScreen internally). You will have to talk to Martin and Sebas about that.


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127316/#review93358
-----------------------------------------------------------


On March 9, 2016, 6:20 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127316/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 6:20 p.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> All the information needed is already provided by Qt through QScreen API, there's no need to use KScreen for that.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 897ba01 
>   src/CMakeLists.txt e1eb3c1 
>   src/PlatformBackends/X11ImageGrabber.h e6ad26f 
>   src/PlatformBackends/X11ImageGrabber.cpp e07785a 
> 
> Diff: https://git.reviewboard.kde.org/r/127316/diff/
> 
> 
> Testing
> -------
> 
> Tested on single-screen setup.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160320/df4c2f79/attachment.html>