[Kde-graphics-devel] Review Request 127316: Remove unnecessary KScreen dependency

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127316/#review93358
-----------------------------------------------------------



I haven't read into the source code of QScreen, but the reason I wrote this using KScreen instead of QScreen was that with KScreen I was sure I was getting data about physical screens, while with QScreen something about the documentation led me to suspect that the term "screen" encompasses a logical screen, not a physical one, and in some cases may stretch across multiple physical outputs.

I can give this a Ship It **only** if someone can confirm that qApp->screens() will *always* map one-to-one with physical outputs. I also strongly suspect that in Wayland we'll *have* to use KScreen anyway.

- Boudhayan Gupta


On March 9, 2016, 10:50 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127316/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 10:50 p.m.)
> 
> 
> Review request for KDE Graphics and Boudhayan Gupta.
> 
> 
> Repository: spectacle
> 
> 
> Description
> -------
> 
> All the information needed is already provided by Qt through QScreen API, there's no need to use KScreen for that.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 897ba01 
>   src/CMakeLists.txt e1eb3c1 
>   src/PlatformBackends/X11ImageGrabber.h e6ad26f 
>   src/PlatformBackends/X11ImageGrabber.cpp e07785a 
> 
> Diff: https://git.reviewboard.kde.org/r/127316/diff/
> 
> 
> Testing
> -------
> 
> Tested on single-screen setup.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160309/62cc3ec7/attachment.html>