Review Request 128622: Port away from kDebug
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Sun Aug 7 17:58:07 UTC 2016
> On Aug. 7, 2016, 12:27 p.m., Martin Koller wrote:
> > I'm fine with the changes, however I think it is not necessary to have all these separate debug areas since
> > almost all of them are wrapped in another ifdef and therefore won't be compiled in anyway.
> > I think just changing kDebug() -> qDebug() would be enough.
The nice thing about qCDebug is that turning the debugging on/off for the various areas can be done at runtime fairly easily.
But I can either remove the ifdefs or change the QCDebug to qDebug if you want to.
- Martin Tobias Holmedahl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128622/#review98167
-----------------------------------------------------------
On Aug. 7, 2016, 5:57 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128622/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2016, 5:57 p.m.)
>
>
> Review request for KDE Graphics, Alexander Potashev and Martin Koller.
>
>
> Repository: kolourpaint
>
>
> Description
> -------
>
> This changes all the kDebug calls to qCDebug with an appropriate category so that debug output in various parts of the code can be turned on and off individually.
>
> For details see here: https://doc.qt.io/qt-5/qloggingcategory.html#configuring-categories
>
>
> Diffs
> -----
>
> CMakeLists.txt dabd490
> commands/imagelib/effects/kpEffectBalanceCommand.cpp 0dfe028
> commands/imagelib/effects/kpEffectBlurSharpenCommand.cpp 9a48aee
> commands/imagelib/effects/kpEffectClearCommand.cpp 748f184
> commands/imagelib/effects/kpEffectEmbossCommand.cpp 1d08c62
> commands/imagelib/effects/kpEffectFlattenCommand.cpp d696cd2
> commands/imagelib/effects/kpEffectInvertCommand.cpp 6b8e2f8
> commands/imagelib/effects/kpEffectReduceColorsCommand.cpp c0499ec
> commands/imagelib/effects/kpEffectToneEnhanceCommand.cpp 83ae3c7
> commands/imagelib/transforms/kpTransformFlipCommand.cpp 221d8c9
> commands/imagelib/transforms/kpTransformResizeScaleCommand.cpp 5fbf996
> commands/imagelib/transforms/kpTransformRotateCommand.cpp 36f2ad0
> commands/imagelib/transforms/kpTransformSkewCommand.cpp 227c751
> commands/kpCommandHistory.cpp 640b893
> commands/kpCommandHistoryBase.cpp b5a0d5a
> commands/kpCommandSize.cpp f20629f
> commands/kpMacroCommand.cpp d933451
> commands/tools/flow/kpToolFlowCommand.cpp 2b99c40
> commands/tools/kpToolFloodFillCommand.cpp c812950
> commands/tools/polygonal/kpToolPolygonalCommand.cpp 4849bcd
> commands/tools/rectangular/kpToolRectangularCommand.cpp b316faa
> commands/tools/selection/kpToolImageSelectionTransparencyCommand.cpp 46a6ae7
> commands/tools/selection/kpToolSelectionCreateCommand.cpp 3533b14
> commands/tools/selection/kpToolSelectionDestroyCommand.cpp 773c4b8
> commands/tools/selection/kpToolSelectionMoveCommand.cpp 2f9bdf9
> commands/tools/selection/kpToolSelectionPullFromDocumentCommand.cpp 1285473
> commands/tools/selection/kpToolSelectionResizeScaleCommand.cpp 4713978
> commands/tools/selection/text/kpToolTextChangeStyleCommand.cpp 08cfc07
> commands/tools/selection/text/kpToolTextGiveContentCommand.cpp 5bfee24
> cursors/kpCursorLightCross.cpp 8a5beaf
> dialogs/imagelib/effects/kpEffectsDialog.cpp 8c1f5db
> dialogs/imagelib/kpDocumentMetaInfoDialog.cpp 9111fc8
> dialogs/imagelib/transforms/kpTransformPreviewDialog.cpp acd4315
> dialogs/imagelib/transforms/kpTransformResizeScaleDialog.cpp 6d860f1
> dialogs/imagelib/transforms/kpTransformRotateDialog.cpp 320ac8c
> dialogs/imagelib/transforms/kpTransformSkewDialog.cpp 68bdd6a
> dialogs/kpDocumentSaveOptionsPreviewDialog.cpp 49fe389
> document/kpDocument.cpp a73581f
> document/kpDocumentSaveOptions.cpp ad4a940
> document/kpDocument_Open.cpp 5aebb1c
> document/kpDocument_Save.cpp 13d624e
> document/kpDocument_Selection.cpp 195d2eb
> environments/document/kpDocumentEnvironment.cpp 8a154b4
> generic/widgets/kpResizeSignallingLabel.cpp afbc412
> imagelib/effects/kpEffectBalance.cpp 5606689
> imagelib/effects/kpEffectBlurSharpen.cpp 189097e
> imagelib/effects/kpEffectEmboss.cpp a8b8faa
> imagelib/effects/kpEffectHSV.cpp 228ce6c
> imagelib/effects/kpEffectInvert.cpp 340a148
> imagelib/effects/kpEffectReduceColors.cpp e612815
> imagelib/effects/kpEffectToneEnhance.cpp 4d6e085
> imagelib/kpColor.h 34ea5e3
> imagelib/kpColor.cpp d797675
> imagelib/kpDocumentMetaInfo.cpp 1ca5520
> imagelib/kpFloodFill.cpp 2aaecef
> imagelib/kpPainter.cpp c5b3d69
> imagelib/transforms/kpTransformAutoCrop.cpp 10cf17c
> imagelib/transforms/kpTransformCrop_ImageSelection.cpp 107f61c
> imagelib/transforms/kpTransformCrop_TextSelection.cpp 73162ad
> kpLogCategories.h PRE-CREATION
> kpLogCategories.cpp PRE-CREATION
> kpThumbnail.cpp abcde02
> kpViewScrollableContainer.cpp 4f9f0da
> layers/selections/image/kpAbstractImageSelection.cpp 1c25503
> layers/selections/image/kpFreeFormImageSelection.cpp 9c26982
> layers/selections/image/kpImageSelectionTransparency.cpp 8f2db2d
> layers/selections/kpAbstractSelection.cpp 54e11a7
> layers/selections/kpSelectionDrag.cpp 540be1b
> layers/selections/kpSelectionFactory.cpp 45e2c3b
> layers/selections/text/kpTextSelection.cpp f6df6dd
> layers/selections/text/kpTextSelection_Cursor.cpp f0311a7
> layers/selections/text/kpTextSelection_Paint.cpp d82dfda
> lgpl/generic/kpColorCollection.cpp e21952b
> lgpl/generic/widgets/kpColorCellsBase.cpp 9364c40
> mainWindow/kpMainWindow.cpp 19b4b55
> mainWindow/kpMainWindow_Colors.cpp 485dfcf
> mainWindow/kpMainWindow_Edit.cpp e358b47
> mainWindow/kpMainWindow_File.cpp c13266d
> mainWindow/kpMainWindow_Image.cpp db50dd0
> mainWindow/kpMainWindow_Settings.cpp 0a03d47
> mainWindow/kpMainWindow_StatusBar.cpp 6e2e532
> mainWindow/kpMainWindow_Text.cpp 965a4a5
> mainWindow/kpMainWindow_Tools.cpp aca3005
> mainWindow/kpMainWindow_View.cpp b89a240
> mainWindow/kpMainWindow_View_Thumbnail.cpp d8d04a1
> mainWindow/kpMainWindow_View_Zoom.cpp 3ccfdb7
> pixmapfx/kpPixmapFX_DrawShapes.cpp ccaf580
> pixmapfx/kpPixmapFX_GetSetPixmapParts.cpp 94574c0
> pixmapfx/kpPixmapFX_Transforms.cpp b0fdb3f
> scan/sanedialog.cpp ef82565
> tools/flow/kpToolColorEraser.cpp 52003dd
> tools/flow/kpToolEraser.cpp fc53b6a
> tools/flow/kpToolFlowBase.cpp e46863e
> tools/flow/kpToolSpraycan.cpp 28cb869
> tools/kpTool.cpp 2015409
> tools/kpToolColorPicker.cpp fd1728d
> tools/kpToolFloodFill.cpp 5fd11d0
> tools/kpToolZoom.cpp cbfa6f7
> tools/kpTool_Drawing.cpp e75a522
> tools/kpTool_KeyboardEvents.cpp bce5eea
> tools/kpTool_MouseEvents.cpp 8bfb1d3
> tools/kpTool_OtherEvents.cpp ab98135
> tools/kpTool_Utilities.cpp eaea895
> tools/polygonal/kpToolCurve.cpp c3e102a
> tools/polygonal/kpToolLine.cpp b40f9eb
> tools/polygonal/kpToolPolygon.cpp bfee371
> tools/polygonal/kpToolPolygonalBase.cpp e2f26d8
> tools/polygonal/kpToolPolyline.cpp 4da787c
> tools/rectangular/kpToolRectangularBase.cpp cc899bb
> tools/selection/image/kpAbstractImageSelectionTool_Transparency.cpp 2d54f11
> tools/selection/image/kpToolEllipticalSelection.cpp a9a6a2e
> tools/selection/image/kpToolFreeFormSelection.cpp 86aabfe
> tools/selection/image/kpToolRectSelection.cpp 41ef554
> tools/selection/kpAbstractSelectionTool.cpp f9aa0f1
> tools/selection/kpAbstractSelectionTool_Create.cpp 6fc0aeb
> tools/selection/kpAbstractSelectionTool_KeyboardEvents.cpp 347d913
> tools/selection/kpAbstractSelectionTool_Move.cpp c2372c4
> tools/selection/kpAbstractSelectionTool_ResizeScale.cpp 1fac0ac
> tools/selection/text/kpToolText.cpp 6a7116c
> tools/selection/text/kpToolText_Commands.cpp d875838
> tools/selection/text/kpToolText_Create.cpp 427c6d5
> tools/selection/text/kpToolText_CursorCalc.cpp a6d16b0
> tools/selection/text/kpToolText_InputMethodEvents.cpp 09bc698
> tools/selection/text/kpToolText_KeyboardEvents.cpp 7a0a101
> tools/selection/text/kpToolText_KeyboardEvents_HandleArrowKeys.cpp 7982246
> tools/selection/text/kpToolText_KeyboardEvents_HandleTypingKeys.cpp d47491b
> tools/selection/text/kpToolText_SelectText.cpp 397e723
> tools/selection/text/kpToolText_TextStyle.cpp 1e441e3
> views/kpThumbnailView.cpp 9407851
> views/kpUnzoomedThumbnailView.cpp b574c94
> views/kpView.cpp ad95ca4
> views/kpView_Events.cpp 9a9d2df
> views/kpView_Paint.cpp a5d4f4d
> views/kpView_Selections.cpp f12ceeb
> views/kpZoomedThumbnailView.cpp e98518d
> views/kpZoomedView.cpp 8a5cf5d
> views/manager/kpViewManager.cpp 7671b1f
> views/manager/kpViewManager_TextCursor.cpp ffd8f28
> views/manager/kpViewManager_ViewUpdates.cpp c572bef
> widgets/colorSimilarity/kpColorSimilarityCubeRenderer.cpp ca80199
> widgets/colorSimilarity/kpColorSimilarityFrame.cpp 3d341f0
> widgets/colorSimilarity/kpColorSimilarityHolder.cpp 01f1b1a
> widgets/colorSimilarity/kpColorSimilarityToolBarItem.cpp 65692f2
> widgets/imagelib/effects/kpEffectBalanceWidget.cpp c724a5f
> widgets/imagelib/effects/kpEffectBlurSharpenWidget.cpp 46e7955
> widgets/imagelib/effects/kpEffectEmbossWidget.cpp de69c9d
> widgets/imagelib/effects/kpEffectFlattenWidget.cpp 0a76645
> widgets/imagelib/effects/kpEffectHSVWidget.cpp 025c514
> widgets/imagelib/effects/kpEffectInvertWidget.cpp 67ee115
> widgets/imagelib/effects/kpEffectReduceColorsWidget.cpp 03da522
> widgets/imagelib/effects/kpEffectToneEnhanceWidget.cpp bbd163c
> widgets/kpColorCells.cpp 9e8d54f
> widgets/kpDocumentSaveOptionsWidget.cpp ec1f1b3
> widgets/kpDualColorButton.cpp e6d6ee0
> widgets/kpPrintDialogPage.cpp 2bd8699
> widgets/kpTransparentColorCell.cpp 7200dc7
> widgets/toolbars/kpColorToolBar.cpp 63717b4
> widgets/toolbars/kpToolToolBar.cpp cb15e7d
> widgets/toolbars/options/kpToolWidgetBase.cpp 40ac30e
> widgets/toolbars/options/kpToolWidgetBrush.cpp 5d49be7
> widgets/toolbars/options/kpToolWidgetEraserSize.cpp 0e9e98b
> widgets/toolbars/options/kpToolWidgetFillStyle.cpp 0c2f135
> widgets/toolbars/options/kpToolWidgetOpaqueOrTransparent.cpp dd9220f
> widgets/toolbars/options/kpToolWidgetSpraycanSize.cpp 1b7fd73
>
> Diff: https://git.reviewboard.kde.org/r/128622/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20160807/32286f35/attachment-0001.html>
More information about the Kde-graphics-devel
mailing list