[Kde-graphics-devel] Review Request 125230: Initial RR for KF5/Qt5 port of kamera

[Luca Beltrame]

> On Set. 18, 2015, 1:15 p.m., Luca Beltrame wrote:
> > Looks Good Enough(TM) to me. Perhaps wait a couple days more to see if there are further reviews, but it's a Ship It from me. Do you have commit access?
> 
> Christian Butcher wrote:
>     I don't. Thanks for all the suggestions and help with this.

All right. Ping me tomorrow here if you haven't got any other revisions and I'll commit it for you. If you are considering further contributions, you may want to apply for a contributor account.


- Luca


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125230/#review85615
-----------------------------------------------------------


On Set. 18, 2015, 12:24 p.m., Christian Butcher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125230/
> -----------------------------------------------------------
> 
> (Updated Set. 18, 2015, 12:24 p.m.)
> 
> 
> Review request for KDE Graphics, Localization and Translation (l10n), Christoph Feck, and Jeremy Whiting.
> 
> 
> Repository: kamera
> 
> 
> Description
> -------
> 
> Initial RR for port of kamera to KF5/Qt5
> 
> Adds 'camera:/' protocol to kio
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a201c0d9ea85e1c437fe991a1b1496622dffd930 
>   COPYING-CMAKE-SCRIPTS PRE-CREATION 
>   FindGphoto2.cmake PRE-CREATION 
>   doc/CMakeLists.txt 6d5f6929d3d2f8276322456b78608a4f656414af 
>   doc/index.docbook 8bd7a76cf694c9e5bec7b6f4ea995c60a285848f 
>   kcontrol/CMakeLists.txt 9e6603f3e121bf56bccebecb6927831ffb77848e 
>   kcontrol/kamera.cpp 3e6540a5a49112bd00693486a0b815e551c6f6eb 
>   kcontrol/kamera.desktop cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97 
>   kcontrol/kamera.h a91149dba6828687fc84a0e0892c3d6874b49362 
>   kcontrol/kameraconfigdialog.h 4f0ee67f37165b8dd424694032001cdc6cf18b57 
>   kcontrol/kameraconfigdialog.cpp b0d601f83dfd0649da533d3bd29ffd46914c6403 
>   kcontrol/kameradevice.h 828eda4df28a24d169f179abf6c43a8afa640fe7 
>   kcontrol/kameradevice.cpp 38f17871838a8847eef864d0a7ba429929ef46af 
>   kioslave/CMakeLists.txt ddf8f2cd6840b50b27157e6d57dc96244afbd613 
>   kioslave/kamera.h b072fca34252228392868750a2714ff3812d3aeb 
>   kioslave/kamera.cpp 081e96f681da708d91f59241ac9273be8f46e4b7 
>   solid_camera.desktop ce419407c372ca1b39c699fec7e583591712b4b1 
> 
> Diff: https://git.reviewboard.kde.org/r/125230/diff/
> 
> 
> Testing
> -------
> 
> Can open camera using the 'camera:/' protocol in Dolphin.
> Can copy files from subdirectories of the camera to my $HOME directory.
> These files open properly.
> 
> Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.
> 
> ~/.xsession-errors calls the destructor appropriately when disconnecting the camera.
> 
> 
> Thanks,
> 
> Christian Butcher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150918/7258c53b/attachment.html>