<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125230/">https://git.reviewboard.kde.org/r/125230/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On settembre 18th, 2015, 1:15 p.m. CEST, <b>Luca Beltrame</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks Good Enough(TM) to me. Perhaps wait a couple days more to see if there are further reviews, but it's a Ship It from me. Do you have commit access?</p></pre>
</blockquote>
<p>On settembre 18th, 2015, 2:34 p.m. CEST, <b>Christian Butcher</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't. Thanks for all the suggestions and help with this.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All right. Ping me tomorrow here if you haven't got any other revisions and I'll commit it for you. If you are considering further contributions, you may want to apply for a contributor account.</p></pre>
<br />
<p>- Luca</p>
<br />
<p>On settembre 18th, 2015, 12:24 p.m. CEST, Christian Butcher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, Localization and Translation (l10n), Christoph Feck, and Jeremy Whiting.</div>
<div>By Christian Butcher.</div>
<p style="color: grey;"><i>Updated Set. 18, 2015, 12:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Initial RR for port of kamera to KF5/Qt5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds 'camera:/' protocol to kio</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can open camera using the 'camera:/' protocol in Dolphin.
Can copy files from subdirectories of the camera to my $HOME directory.
These files open properly.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Cannot open files in place on the camera, but suspect this due to a consolekit2 session management issue on my computer. ~/.xsession-errors describes the camera as busy for the 15 'tries' as handled by 'kioslace/kamera.cpp' in 'openKamera' function.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">~/.xsession-errors calls the destructor appropriately when disconnecting the camera.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a201c0d9ea85e1c437fe991a1b1496622dffd930)</span></li>
<li>COPYING-CMAKE-SCRIPTS <span style="color: grey">(PRE-CREATION)</span></li>
<li>FindGphoto2.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(6d5f6929d3d2f8276322456b78608a4f656414af)</span></li>
<li>doc/index.docbook <span style="color: grey">(8bd7a76cf694c9e5bec7b6f4ea995c60a285848f)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(9e6603f3e121bf56bccebecb6927831ffb77848e)</span></li>
<li>kcontrol/kamera.cpp <span style="color: grey">(3e6540a5a49112bd00693486a0b815e551c6f6eb)</span></li>
<li>kcontrol/kamera.desktop <span style="color: grey">(cb5c7845ba4b57bf3bb3a23e548ef00efcff7a97)</span></li>
<li>kcontrol/kamera.h <span style="color: grey">(a91149dba6828687fc84a0e0892c3d6874b49362)</span></li>
<li>kcontrol/kameraconfigdialog.h <span style="color: grey">(4f0ee67f37165b8dd424694032001cdc6cf18b57)</span></li>
<li>kcontrol/kameraconfigdialog.cpp <span style="color: grey">(b0d601f83dfd0649da533d3bd29ffd46914c6403)</span></li>
<li>kcontrol/kameradevice.h <span style="color: grey">(828eda4df28a24d169f179abf6c43a8afa640fe7)</span></li>
<li>kcontrol/kameradevice.cpp <span style="color: grey">(38f17871838a8847eef864d0a7ba429929ef46af)</span></li>
<li>kioslave/CMakeLists.txt <span style="color: grey">(ddf8f2cd6840b50b27157e6d57dc96244afbd613)</span></li>
<li>kioslave/kamera.h <span style="color: grey">(b072fca34252228392868750a2714ff3812d3aeb)</span></li>
<li>kioslave/kamera.cpp <span style="color: grey">(081e96f681da708d91f59241ac9273be8f46e4b7)</span></li>
<li>solid_camera.desktop <span style="color: grey">(ce419407c372ca1b39c699fec7e583591712b4b1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125230/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>