[Kde-graphics-devel] Review Request 121796: ksnapshot: fix temp file handling

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121796/#review72996
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Led. 2, 2015, 11:23 odp., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121796/
> -----------------------------------------------------------
> 
> (Updated Led. 2, 2015, 11:23 odp.)
> 
> 
> Review request for KDE Graphics, KSnapshot, David Faure, and Lukáš Tinkl.
> 
> 
> Repository: ksnapshot
> 
> 
> Description
> -------
> 
> Fixes the bug discovered by David:
> 
> ```
> It deletes the QTemporaryFile just after saving to it.
> 
> Lukas, this is due to your removal of tmpFile.setAutoRemove(false) in
> 3bc66a71b02704f9e70ffb8239c886a1b61154c9
> 
> It makes KSnapshot::urlToOpen delete the file right away, i.e. it returns a 
> path to a file that doesn't exist anymore. No wonder kio can't find it.
> ```
> 
> 
> Diffs
> -----
> 
>   ksnapshot.cpp 0d00e0ee378b66788f618becdf6fa6db427e5c06 
> 
> Diff: https://git.reviewboard.kde.org/r/121796/diff/
> 
> 
> Testing
> -------
> 
> SendTo works for Kolourpaint, MyPaint, ImageViewer, ...
> 
> With Gwenview, there is still the command line parsing error:
> 
> ```
> $KDEDIR/lib64/libexec/kf5/kioexec --tempfiles 'gwenview %U' -caption Gwenview 
> --icon gwenview /tmp/route.png
> Unknown options: c, a, p, t, i, o, n, icon.
> ```
> 
> This is independent of this RR.
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150103/a9c0d406/attachment.html>