<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121796/">https://git.reviewboard.kde.org/r/121796/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship It!</p></pre>
<br />
<p>- Lukáš Tinkl</p>
<br />
<p>On leden 2nd, 2015, 11:23 odp. CET, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Graphics, KSnapshot, David Faure, and Lukáš Tinkl.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Led. 2, 2015, 11:23 odp.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes the bug discovered by David:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">It deletes the QTemporaryFile just after saving to it.
Lukas, this is due to your removal of tmpFile.setAutoRemove(<span style="color: #008000">false</span>) in
<span style="color: #666666">3</span>bc66a71b02704f9e70ffb8239c886a1b61154c9
It makes KSnapshot<span style="color: #666666">::</span>urlToOpen delete the file right away, i.e. it returns a
path to a file that doesn<span style="border: 1px solid #FF0000">'</span>t exist anymore. No wonder kio can<span style="border: 1px solid #FF0000">'</span>t find it.
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SendTo works for Kolourpaint, MyPaint, ImageViewer, ...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With Gwenview, there is still the command line parsing error:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="border: 1px solid #FF0000">$</span>KDEDIR<span style="color: #666666">/</span>lib64<span style="color: #666666">/</span>libexec<span style="color: #666666">/</span>kf5<span style="color: #666666">/</span>kioexec <span style="color: #666666">--</span>tempfiles <span style="border: 1px solid #FF0000">'</span>gwenview <span style="color: #666666">%</span>U<span style="border: 1px solid #FF0000">'</span> <span style="color: #666666">-</span>caption Gwenview
<span style="color: #666666">--</span>icon gwenview <span style="color: #666666">/</span>tmp<span style="color: #666666">/</span>route.png
Unknown options<span style="color: #666666">:</span> c, a, p, t, i, o, n, icon.
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is independent of this RR.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksnapshot.cpp <span style="color: grey">(0d00e0ee378b66788f618becdf6fa6db427e5c06)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>