[Kde-graphics-devel] Review Request 122737: Re-origanise code in the frameworks branch

[Boudhayan Gupta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122737/
-----------------------------------------------------------

(Updated Feb. 27, 2015, 7:06 p.m.)


Review request for KSnapshot and Aleix Pol Gonzalez.


Changes
-------

As per aseigo's feedback, the patch now does only the following:

* Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives
* Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
* The KSnapshot version is now defined in the top-level CMakeLists.txt

The patch is a little bigger than it should be because I've moved things around in main.cpp (I was playing with adding a listener for the KDBusService::activateRequested signal, and re-ordered the lines - no code added - and added in a bunch of comments in main.cpp). The excessive size of changes in main.cpp should be attributed to this - to re-do this patch, I just took my changed main.cpp file, deleted the listener function and the connect line, and added it into the diff. main.cpp should be cleaner to read now anyway.

I should probably mention here what I'm playing with  - what I'm trying to do with KDBusService, eventually, is set it to Unique and simply raise the existing window when it's called a second time. Right now when you press the 'Q' key on the keyboard, a screenshot is taken and automatically saved somewhere with a fixed filename. I'm trying to do the same with the PrintScreen key - so that if KSnapshot is open and I press PrintScreen, another window doesn't open, but the existing screenshot is saved somewhere sane - with a sane filename - and KSnapshot is reset to do something else again.


Repository: ksnapshot


Description
-------

This is a pretty big patch. It does the following:

* Move all the .cpp and .h files to an "src" directory
* Move the XDG desktop file to a "desktop" directory
* Move the SVG icon source for the hicolor icon to the icons directory
* Refactor the CMakeLists.txt file
* Give each subdirectory (src, icons, desktop) its own CMakeLists.txt. doc already had one.
* Guard config-ksnapshot.h.cmake contents within ifndef-define-endif preprocessor directives
* Move the KSNAPVERSION define from main.cpp to config-ksnapshot.h.cmake
* The KSnapshot version is now defined in the top-level CMakeLists.txt


Diffs (updated)
-----

  CMakeLists.txt d174abf 
  Messages-i18n.sh PRE-CREATION 
  Messages-qt.sh PRE-CREATION 
  Messages.sh d242e38 
  config-ksnapshot.h.cmake 3514dd5 
  main.cpp ef03554 

Diff: https://git.reviewboard.kde.org/r/122737/diff/


Testing
-------

Builds and installs fine. No functionality was added in this patch, so didn't test much beyond build/run/take screenshots.


Thanks,

Boudhayan Gupta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-graphics-devel/attachments/20150227/913b9c19/attachment-0001.html>